This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [ping] [PATCH] Different outputs affected by locale
- From: Yao Qi <yao at codesourcery dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Wed, 4 Jun 2014 21:18:59 +0800
- Subject: Re: [ping] [PATCH] Different outputs affected by locale
- Authentication-results: sourceware.org; auth=none
- References: <1401192650-29688-1-git-send-email-yao at codesourcery dot com> <538EAEE5 dot 2080708 at codesourcery dot com> <20140604124708 dot GR4289 at adacore dot com>
On 06/04/2014 08:47 PM, Joel Brobecker wrote:
>>> 2014-05-27 Yao Qi <yao@codesourcery.com>
>>>
>>> * gdb.base/wchar.exp: Execute command 'p repeat[1]' and extract
>>> cent from the output.
>
> This is a patch that I felt would be better reviewed by Tom, but
> we'd have to wait for him to be back. When I read your patch,
> I thought that the approach you took was weakening the test a little,
> because if GDB started printing the character incorrectly, you would
> not notice it anymore.
>
The character printed by GDB in this case is out the control of GDB,
IMO. IOW, we can't tell what character printed is correct and what is
incorrect. Or we can relax the pattern to match either \242 or 'Â'
(cent sign) in the test. WDYT?
--
Yao (éå)