This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 0/2 v3] Demangler crash handler
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Gary Benson <gbenson at redhat dot com>
- Cc: gdb-patches at sourceware dot org, aburgess at broadcom dot com, xdje42 at gmail dot com, fw at deneb dot enyo dot de, mark dot kettenis at xs4all dot nl, palves at redhat dot com, tromey at redhat dot com
- Date: Wed, 04 Jun 2014 13:21:36 +0300
- Subject: Re: [PATCH 0/2 v3] Demangler crash handler
- Authentication-results: sourceware.org; auth=none
- References: <20140604100755 dot GA7570 at blade dot nx>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Wed, 4 Jun 2014 11:07:55 +0100
> From: Gary Benson <gbenson@redhat.com>
> Cc: Andrew Burgess <aburgess@broadcom.com>, Doug Evans <xdje42@gmail.com>, Eli Zaretskii <eliz@gnu.org>, Florian Weimer <fw@deneb.enyo.de>, Mark Kettenis <mark.kettenis@xs4all.nl>, Pedro Alves <palves@redhat.com>, Tom Tromey <tromey@redhat.com>
>
> I would push both patches as one commit. The news file entries
> for the commit would be:
>
> * New options
>
> maint set catch-demangler-crashes (on|off)
> maint show catch-demangler-crashes
> Control whether GDB should attempt to catch crashes in the symbol
> name demangler. The default is to attempt to catch crashes. If
> enabled, the first time a crash is caught, a core file is created,
> the offending symbol is displayed and the user is presented with
> the option to terminate the current session.
>
> maint set demangler-warning quit (yes|no|ask)
> When GDB catches a crash in the symbol name demangler it can offer
> the user the opportunity to both quit GDB and create a core file of
> the current GDB session. These options control whether or not to
> do either of these. The default is to create a core file and to ask
> the user whether to quit.
>
> * New commands
>
> maint demangler-warning
> Cause GDB to call the internal function demangler_warning and
> hence behave as though an internal error in the demangler has
> been detected.
>
> Is this ok to commit?
The above is too detailed for NEWS. Do not just copy the text from
the manual, but instead provide a very short (preferably a
single-sentence) summary of the new option.
Thanks.