This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH, doc RFA] Split create-breakpoint! into make-breakpoint, register-breakpoint!
- From: ludo at gnu dot org (Ludovic CourtÃs)
- To: Doug Evans <xdje42 at gmail dot com>
- Cc: eliz at gnu dot org, gdb-patches at sourceware dot org
- Date: Wed, 04 Jun 2014 10:30:22 +0200
- Subject: Re: [PATCH, doc RFA] Split create-breakpoint! into make-breakpoint, register-breakpoint!
- Authentication-results: sourceware.org; auth=none
- References: <m3egz5cm1v dot fsf at sspiff dot org>
Doug Evans <xdje42@gmail.com> skribis:
> In keeping with the splitting of object creation and registration into
> two separate pieces, this does the same for breakpoints.
> "Consistency Is Good".
That makes sense.
> There hasn't been an FSF release of gdb+guile yet so I think it's ok
> to remove create-breakpoint! here.
Yup.
> 2014-06-03 Doug Evans <xdje42@gmail.com>
>
> * guile/scm-breakpoint.c (struct gdbscm_breakpoint_object): New members
> is_scheme_bkpt, spec.
> (bpscm_make_breakpoint_smob): Initialize new members.
> (gdbscm_create_breakpoint_x): Split into two ...
> (gdbscm_make_breakpoint, gdbscm_register_breakpoint_x): New functions.
> (bpscm_breakpoint_deleted): Reset breakpoint number and stop function.
> (scheme_function breakpoint_functions): Update.
>
> testsuite/
> * gdb.guile/scm-breakpoint.exp: Update.
> Add tests for breakpoint registration.
>
> doc/
> * guile.texi (Breakpoints In Guile): Update.
LGTM.
Ludoâ.