This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH, doc RFA] Add guile gdb command support
- From: ludo at gnu dot org (Ludovic CourtÃs)
- To: Doug Evans <xdje42 at gmail dot com>
- Cc: Eli Zaretskii <eliz at gnu dot org>, gdb-patches at sourceware dot org
- Date: Tue, 03 Jun 2014 10:33:06 +0200
- Subject: Re: [PATCH, doc RFA] Add guile gdb command support
- Authentication-results: sourceware.org; auth=none
- References: <m34n0jhqy7 dot fsf at sspiff dot org> <83k39dn7ne dot fsf at gnu dot org> <m3vbskdv9d dot fsf at sspiff dot org> <83wqcz9vil dot fsf at gnu dot org> <m3ppiqcus8 dot fsf at sspiff dot org>
Hi,
Doug Evans <xdje42@gmail.com> skribis:
> commit e698b8c41cbb2648a11a2ae806922c44d1482aed
> Author: Doug Evans <xdje42@gmail.com>
> Date: Tue Jun 3 00:29:49 2014 -0700
>
> Add command support for Guile.
>
> * Makefile.in (SUBDIR_GUILE_OBS): Add scm-cmd.o.
> (SUBDIR_GUILE_SRCS): Add scm-cmd.c.
> (scm-cmd.o): New rule.
> * guile/guile-internal.h (gdbscm_gc_xstrdup): Declare.
> (gdbscm_user_error_p): Declare.
> (gdbscm_parse_command_name): Declare.
> (gdbscm_valid_command_class_p): Declare.
> (gdbscm_initialize_commands): Declare.
> * guile/guile.c (initialize_gdb_module): Call
> gdbscm_initialize_commands.
> * guile/lib/gdb.scm: Export command symbols.
> * guile/lib/gdb/init.scm (%exception-keys): Add gdb:user-error.
> (throw-user-error): New function.
> * guile/scm-cmd.c: New file.
> * guile/scm-exception.c (user_error_symbol): New static global.
> (gdbscm_user_error_p): New function.
> (gdbscm_initialize_exceptions): Set user_error_symbol.
> * scm-utils.c (gdbscm_gc_xstrdup): New function.
>
> testsuite/
> * gdb.guile/scm-cmd.c: New file.
> * gdb.guile/scm-cmd.exp: New file.
>
> doc/
> * guile.texi (Guile API): Add entry for Commands In Guile.
> (Basic Guile) <parse-and-eval>: Add reference.
> (Basic Guile) <string->argv>: Move definition to Commands In Guile.
> (GDB Scheme Data Types): Mention <gdb:command> object.
> (Commands In Guile): New node.
Looks great to me (sorry for not commenting earlier.)
Thanks,
Ludoâ.