This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3 1/4] New test for backtrace when the stack pointer is invalid (inaccessible).
- From: Pedro Alves <palves at redhat dot com>
- To: Andrew Burgess <aburgess at broadcom dot com>, gdb-patches at sourceware dot org
- Date: Wed, 28 May 2014 19:42:03 +0100
- Subject: Re: [PATCH v3 1/4] New test for backtrace when the stack pointer is invalid (inaccessible).
- Authentication-results: sourceware.org; auth=none
- References: <533EC5B7 dot 6080600 at broadcom dot com> <1398855344-25278-1-git-send-email-aburgess at broadcom dot com> <1398855344-25278-2-git-send-email-aburgess at broadcom dot com>
On 04/30/2014 11:55 AM, Andrew Burgess wrote:
> +
> +#include <sys/mman.h>
> +#include <unistd.h>
> +#include <assert.h>
> +
> +void
> +breakpt ()
'(void)' here and elsewhere.
> +int
> +main ()
Otherwise looks fine.
(I'd have slightly preferred that the patch
for the crash included the test, adjusted as necessary, and
then the follow up patches added / built on the existing test.)
Thanks,
--
Pedro Alves