This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 08/12] NIOS2 Linux: Fill 'collect_regset' in regset structure.
- From: Yao Qi <yao at codesourcery dot com>
- To: Andreas Arnez <arnez at linux dot vnet dot ibm dot com>, <gdb-patches at sourceware dot org>
- Date: Tue, 27 May 2014 10:12:25 +0800
- Subject: Re: [PATCH 08/12] NIOS2 Linux: Fill 'collect_regset' in regset structure.
- Authentication-results: sourceware.org; auth=none
- References: <1401122208-2481-1-git-send-email-arnez at linux dot vnet dot ibm dot com> <1401122208-2481-9-git-send-email-arnez at linux dot vnet dot ibm dot com>
On 05/27/2014 12:36 AM, Andreas Arnez wrote:
> +#define NIOS2_GREGS_SIZE (4 * 31)
> +
Is it used?
> /* Implement the supply_regset hook for core files. */
>
> static void
> @@ -73,11 +75,26 @@ nios2_supply_gregset (const struct regset *regset,
> }
> }
>
> +static void
> +nios2_collect_gregset (const struct regset *regset,
> + const struct regcache *regcache,
> + int regnum, void *gregs_buf, size_t len)
The comment to this function is needed, like the comment to
nios2_supply_gregset.
> +{
> + gdb_byte *gregs = gregs_buf;
> + int regno;
> +
> + for (regno = NIOS2_Z_REGNUM; regno <= NIOS2_MPUACC_REGNUM; regno++)
> + if (regnum == -1 || regnum == regno)
> + {
> + if (reg_offsets[regno] != -1)
> + regcache_raw_collect (regcache, regno,
> + gregs + 4 * reg_offsets[regno]);
> + }
> +}
> +
> static const struct regset nios2_core_regset =
> {
> - NULL,
> - nios2_supply_gregset,
> - NULL,
> + NULL, nios2_supply_gregset, nios2_collect_gregset
> };
I'd like to put each field in one line. Otherwise, it is OK.
--
Yao (éå)