RE: [Patch, microblaze]: Add slr and shr regs

[Ajit Kumar Agarwal <ajit dot kumar dot agarwal at xilinx dot com>]

Based on the feedback and incorporated all review comment, updated the patch.

 [Patch, microblaze]: Add slr and shr regs

   Prior to version x.xx, XMD's gdbserver stub returned 57 registers in
   response to GDB's G request.  Starting with version x.xx, XMD added the
   slr and shr register, for a count of 59 registers.  This patch adds
   these registers to the expected G response

ChangeLog:
2014-05-26 Ajit Agarwal <ajitkum@xilinx.com>

        * Makefile.in (microblaze-linux.c): New rule.

        * microblaze-tdep.c (microblaze_register_names): Add
        the rshr and rslr register names.

        * microblaze-tdep.h (microblaze_reg_num): Add
        field MICROBLAZE_SLR_REGNUM and MICROBLAZE_SHR_REGNUM
        MICROBLAZE_NUM_REGS.
        (microblaze_frame_cache): Use of MICROBLAZE_NUM_REGS.

        * features/microblaze-cpu.xml: New file.

        * features/microblaze-linux.c: New file.

        * features/microblaze-linux.xml: New file.

        * regformats/reg-microblaze.dat: New file.

        * features/Makefile (microblaze-linux): Add
        microblaze-linux and microblaze-expedite.

Signed-off-by:Ajit Agarwal ajitkum@xilinx.com

Thanks & Regards
Ajit
-----Original Message-----
From: Michael Eager [mailto:eager@eagercon.com] 
Sent: Saturday, May 24, 2014 4:13 AM
To: Ajit Kumar Agarwal; gdb-patches@sourceware.org
Cc: Joel Brobecker; Vinod Kathail; Vidhumouli Hunsigida; Nagaraju Mekala
Subject: Re: [Patch, microblaze]: Add slr and shr regs

On 05/23/14 02:46, Ajit Kumar Agarwal wrote:
>
>
>>> Let's try this one more time:  GDB is connected to something when you tell it to connect to the target with the "target remote" command.
>>> This is returning a different sized G packet.  What is it that you are connecting to?
>
> Here is the flow from GBD Client to XMD that's what is happening:
>
> 1. XMD connects to the hardware target through JTAG.
> 2. XMD Opens a GDB Server on the local host 1234.
> 3. GDB Client will connect to  the host:1234 through TCP, when the command "tar remote localhost:1234" is given.

Ajit --

Let me suggest this description of the problem:
   Prior to version x.xx, XMD's gdbserver stub returned 57 registers in
   response to GDB's G request.  Starting with version x.xx, XMD added the
   slr and shr register, for a count of 59 registers.  This patch adds
   these registers to the expected G response.

Please resubmit the patch, in full, with ChangeLog.


-- 
Michael Eager	 eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306  650-325-8077

Attachment: 0001-Patch-microblaze-Add-slr-and-shr-regs.patch
Description: 0001-Patch-microblaze-Add-slr-and-shr-regs.patch