This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch AArch64] Include asm/ptrace.h in aarch64-linux-nat.c


> 	A recent change to glibc removed asm/ptrace.h from user.h for
> AArch64. This meant that cross-native builds of gdb using trunk
> glibc broke because aarch64-linux-nat.c because user_hwdebug_state
> couldn't be found.
> 
> Fixed by including asm/ptrace.h like other ports.

Thanks for the explanation. Can you make sure you include that
in the revision history of your commit?

> 2014-05-22  Ramana Radhakrishnan  <ramana.radhakrishnan@arm.com>
> 
>        * aarch64-linux-nat.c (asm/ptrace.h): Include.
> 

OK to push.  Thank you.


> commit 53278fc086b53264d75ec9cb2a4929565276100a
> Author: Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
> Date:   Thu May 22 09:41:41 2014 +0100
> 
>     Include asm/ptrace.h for recent glibc changes.
> 
> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> index 6f5c9c2..95df3e1 100644
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -1,5 +1,9 @@
>  2014-05-22  Ramana Radhakrishnan  <ramana.radhakrishnan@arm.com>
>  
> +	* aarch64-linux-nat.c (asm/ptrace.h): Include.
> +
> +2014-05-22  Ramana Radhakrishnan  <ramana.radhakrishnan@arm.com>
> +
>  	* MAINTAINERS (Write After Approval): Move self back from
>  	Paper trail.
>  
> diff --git a/gdb/aarch64-linux-nat.c b/gdb/aarch64-linux-nat.c
> index 28ad38b..877e702 100644
> --- a/gdb/aarch64-linux-nat.c
> +++ b/gdb/aarch64-linux-nat.c
> @@ -33,6 +33,7 @@
>  
>  #include <sys/ptrace.h>
>  #include <sys/utsname.h>
> +#include <asm/ptrace.h>
>  
>  #include "gregset.h"
>  


-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]