This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/3] [GDBserver] Make Zx/zx packet handling idempotent.
- From: Yao Qi <yao at codesourcery dot com>
- To: Pedro Alves <palves at redhat dot com>, <gdb-patches at sourceware dot org>
- Date: Wed, 21 May 2014 10:28:26 +0800
- Subject: Re: [PATCH 3/3] [GDBserver] Make Zx/zx packet handling idempotent.
- Authentication-results: sourceware.org; auth=none
- References: <1398296475-27997-1-git-send-email-palves at redhat dot com> <1398296475-27997-4-git-send-email-palves at redhat dot com>
The patch is good!
On 04/24/2014 07:41 AM, Pedro Alves wrote:
> So the fix is to generalize mem-break.c to track all kinds of Zx
> breakpoints, and filter out duplicates. As mentioned, this ends up
> adding support for target-side conditions on hardware breakpoints and
> watchpoints too (though GDB itself doesn't support the latter yet).
>
Can GDBserver returns feature "ConditionalWatchpoints" for qSupported
query now?
> As software/memory breakpoints work by poking at memory, when setting
> a GDB Z0 breakpoint (but not internal breakpoints, as those can assume
> the conditions are already right), we need to tell the target to
> prepare to access memory (which on Linux means stop threads). If that
> operation fails, we need to return error to GDB. Seeing an error, if
> this is the first breakpoint of that type that GDB tries to insert,
> GDB would then assume the breakpoint type is supported, but it may
> actually not be. So we need to check whether the type is supported at
I am confused by this, isn't it "GDB would then assume the breakpoint
type is NOT supported, but it may actually be"?
--
Yao (éå)