This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v5 6/8] gdbserver build-id attribute generator


>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> producer part of the new "build-id" XML attribute.

I can't really claim to understand all of this patch.
What I do understand looks reasonable, and I'm prepared to approve it
given its history, etc.

However:

Jan> -<!ATTLIST library-list-svr4  version CDATA   #FIXED  "1.0">
Jan> -<!ATTLIST library-list-svr4  main-lm CDATA   #IMPLIED>
Jan> +<!ATTLIST library-list-svr4  version  CDATA   #FIXED  "1.0">
Jan> +<!ATTLIST library-list-svr4  main-lm  CDATA   #IMPLIED>

I am concerned about versioning of the XML.
Is it correct to keep the same version number?
If so -- why?

Perhaps we consider it compatible to add attributes.
I really don't know; nor did I find anything in the documentation.
So at the very least this needs an update to the manual to warn
future users.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]