This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 1/3] btrace: control memory access during replay
- From: Pedro Alves <palves at redhat dot com>
- To: Markus Metzger <markus dot t dot metzger at intel dot com>
- Cc: gdb-patches at sourceware dot org, Eli Zaretskii <eliz at gnu dot org>
- Date: Tue, 20 May 2014 13:26:03 +0100
- Subject: Re: [PATCH v2 1/3] btrace: control memory access during replay
- Authentication-results: sourceware.org; auth=none
- References: <1400587236-18836-1-git-send-email-markus dot t dot metzger at intel dot com>
On 05/20/2014 01:00 PM, Markus Metzger wrote:
> The btrace record target does not trace data. We therefore do not allow
> accessing read-write memory during replay.
>
> In some cases, this might be useful to advanced users, though, who we assume
> to know what they are doing.
>
> Add a set|show command pair to turn this memory access restriction off.
>
The code bits are OK.
> + /* Record instructions number limit command. */
This comment looks like a pasto.
> + add_setshow_enum_cmd ("replay-memory-access", no_class,
> + replay_memory_access_types, &replay_memory_access, _("\
Thanks,
--
Pedro Alves