This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix prologue analysis for ldr.w and ldrd instruction
- From: Joel Brobecker <brobecker at adacore dot com>
- To: tmirza <tmirza at codesourcery dot com>
- Cc: Will Newton <will dot newton at linaro dot org>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Mon, 19 May 2014 08:11:22 -0700
- Subject: Re: [PATCH] Fix prologue analysis for ldr.w and ldrd instruction
- Authentication-results: sourceware.org; auth=none
- References: <1399448485-1740-1-git-send-email-tmirza at codesourcery dot com> <CANu=DmgMWP=dr=9xxQxcnFC-99M-BjdZa9JQa8vHM_w8Ythkxg at mail dot gmail dot com> <20140507132511 dot GB4063 at adacore dot com> <536A5254 dot 3030402 at codesourcery dot com>
> >>>2014-05-06 Taimoor Mirza <tmirza@codesourcery.com>
> >>>
> >>> gdb/
> >>> * arm-tdep.c (thumb_analyze_prologue): Fix offset calculation for
> >>> ldr.w and ldrd instructions.
> >[...]
> >>This looks good to me, assuming the testsuite was run with no regressions.
> Thanks for the review Will. Yes I ran testsuites.
> >Thanks, Will, for reviewing the patch. I concur on both counts:
> >patch is approved, but can you please also confirm how the patch
> >was tested?
> I ran testsuites before and after applying my patch and did not find
> any regression.
I noticed that there is a new branch on the binutils-gdb repository
called CB-2131, and that branch only contains your patch. Does this
ring a bell to you? Perhaps that's the name of the branch you used
on your end and you pushed it by accident?
Thanks,
--
Joel