This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3 2/4] Remove previous frame if an error occurs when computing frame id during unwind.
- From: Pedro Alves <palves at redhat dot com>
- To: Andrew Burgess <aburgess at broadcom dot com>, gdb-patches at sourceware dot org
- Date: Fri, 16 May 2014 16:37:01 +0100
- Subject: Re: [PATCH v3 2/4] Remove previous frame if an error occurs when computing frame id during unwind.
- Authentication-results: sourceware.org; auth=none
- References: <533EC5B7 dot 6080600 at broadcom dot com> <1398855344-25278-1-git-send-email-aburgess at broadcom dot com> <1398855344-25278-3-git-send-email-aburgess at broadcom dot com>
On 04/30/2014 11:55 AM, Andrew Burgess wrote:
> In get_prev_frame_if_no_cycle, if we throw an error during compute_frame_id
> then we are left in a state where THIS_FRAME has a PREV_FRAME attached, but
> PREV_FRAME has no frame id. This is an unexpected state that causes
> internal errors and assertions to fire.
>
> This patch adds a cleanup that removes the previous frame created by
> get_prev_frame_raw if we get an error.
>
> OK to apply?
This is OK. Thank you.
(I guess it could go in immediately if you adjust
the test to expect the error and only try each command
once.)
I was looking at the rest of the series, but something came
up and I'm afraid I won't be able to reply today. Sigh. :-(
--
Pedro Alves