This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 0/5] Return error code in get_number
- From: Tom Tromey <tromey at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Thu, 15 May 2014 11:58:12 -0600
- Subject: Re: [PATCH 0/5] Return error code in get_number
- Authentication-results: sourceware.org; auth=none
- References: <1394677950-4054-1-git-send-email-yao at codesourcery dot com> <87d2hqku59 dot fsf at fleche dot redhat dot com> <532253C8 dot 7050507 at codesourcery dot com> <87lhwckfq8 dot fsf at fleche dot redhat dot com> <53264680 dot 9090704 at codesourcery dot com>
Tom> It seems to me that an MI client already knows all the breakpoint
Tom> numbers. I'm having trouble picturing the scenario where I'd want my MI
Tom> client to use a convenience variable instead.
Yao> This facilitates writing MI test cases that we don't have to hard-code
Yao> breakpoint numbers anymore. Keith pointed this out in the review
Yao> https://sourceware.org/ml/gdb-patches/2014-01/msg00824.html and I think
Yao> that is good to have, so I write this patch series. Can this justify
Yao> the changes in this series?
I am not opposed to it but I would like to gently push back a little.
It seems to me that if the proposed patches are there to help with a
deficiency in the test suite, then it would be better to fix the test
suite. Say, by implementing a way to extract the breakpoint number and
make it available to the Tcl code. Did you consider this approach? And
if so what made you reject it?
Tom