This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Prompt user to report bugs
- From: Doug Evans <dje at google dot com>
- To: Gary Benson <gbenson at redhat dot com>
- Cc: Paul Koning <Paul_Koning at dell dot com>, gdb-patches <gdb-patches at sourceware dot org>, Tom Tromey <tromey at redhat dot com>
- Date: Thu, 15 May 2014 10:10:15 -0700
- Subject: Re: [PATCH] Prompt user to report bugs
- Authentication-results: sourceware.org; auth=none
- References: <20140514110742 dot GA25550 at blade dot nx> <CADPb22T0DvL237NkheQ1h0onABvTPUKkXXxZu2Uzh3WdpSbgVA at mail dot gmail dot com> <1B70C5D6-D845-4F9A-A874-63DF77FB9030 at dell dot com> <CADPb22TU7YqQ_k=0e1v2wHRMQUu9Ecmuk3j0N6HVfBgjtes_fQ at mail dot gmail dot com> <20140515113943 dot GB13323 at blade dot nx>
On Thu, May 15, 2014 at 4:39 AM, Gary Benson <gbenson@redhat.com> wrote:
> Doug Evans wrote:
>> On Wed, May 14, 2014 at 2:11 PM, <Paul_Koning@dell.com> wrote:
>> > On May 14, 2014, at 5:05 PM, Doug Evans <dje@google.com> wrote:
>> > > On Wed, May 14, 2014 at 4:07 AM, Gary Benson <gbenson@redhat.com> wrote:
>> > > > 2014-05-14 Gary Benson <gbenson@redhat.com>
>> > > >
>> > > > * utils.c (internal_vproblem): Prompt the user to file a report.
>> > > >
>> > > > diff --git a/gdb/utils.c b/gdb/utils.c
>> > > > index a8a7cb3..905ce6d 100644
>> > > > --- a/gdb/utils.c
>> > > > +++ b/gdb/utils.c
>> > > > @@ -746,6 +746,14 @@ internal_vproblem (struct internal_problem *problem,
>> > > > else
>> > > > internal_error (__FILE__, __LINE__, _("bad switch"));
>> > > >
>> > > > + fputs_unfiltered (_("\nThis is a bug, please report it."), gdb_stderr);
>> > > > + if (REPORT_BUGS_TO[0])
>> > > > + {
>> > > > + fputs_unfiltered (_(" For instructions, see:\n"), gdb_stderr);
>> > > > + fprintf_unfiltered (gdb_stderr, _("%s."), REPORT_BUGS_TO);
>> > > > + }
>> > > > + fputs_unfiltered ("\n\n", gdb_stderr);
>> > > > +
>> > > > if (problem->should_dump_core == internal_problem_ask)
>> > > > {
>> > > > if (!can_dump_core (reason))
>> > > >
>> > >
>> > > top.c doesn't wrap "%s." in _().
>> > > I don't know if it matters, it's just odd to see "%s." wrapped.
>> >
>> > It also seems odd to see â%s.â inside _( ) since thereâs nothing
>> > to translate there.
>>
>> That's why it seemed odd to me too. :-)
>> [Though what do I know ... maybe someone might want to use something
>> other than "." at the end.]
>
> Japanese has a different sentence terminator:
> http://en.wikipedia.org/wiki/Japanese_punctuation#Full_stop
> Possibly other languages do to.
Heh. I didn't know that.
Though I was thinking of Chantho when I wrote that. 1/2 :-)
http://tardis.wikia.com/wiki/Chantho
Chan <http://www.gnu.org/software/gdb/bugs/> tho ?
[The Chan would probably go before "For instructions, see", but why
ruin a good (bad?) joke. :)]
> I'm easy either way, if people want it wrapped I'll wrap it,
> if people want it bare I can do that too :)
I don't have a strong preference, other than to be consistent.
If it'd be a protocol violation to change top.c at the same time,
and if no one really cares, then to keep things simple
I'd say stick with what top.c does.