This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH 03/11] AARCH64: Replace regset_alloc() invocations by static regset structures.
- From: Andreas Arnez <arnez at linux dot vnet dot ibm dot com>
- To: gdb-patches at sourceware dot org
- Date: Thu, 15 May 2014 17:49:27 +0200
- Subject: [PATCH 03/11] AARCH64: Replace regset_alloc() invocations by static regset structures.
- Authentication-results: sourceware.org; auth=none
- References: <1400168975-3145-1-git-send-email-arnez at linux dot vnet dot ibm dot com>
After removal of the regset_alloc invocations, the tdep fields
'gregset' and 'fpregset' become obsolete and are thus removed.
gdb/
* aarch64-linux-tdep.c (aarch64_linux_gregset)
(aarch64_linux_fpregset): New static regset structures.
(aarch64_linux_regset_from_core_section): Drop dynamic allocation
of regset structures.
* aarch64-tdep.h (struct gdbarch_tdep): Remove 'gregset' and
'fpregset' fields.
---
gdb/aarch64-linux-tdep.c | 29 +++++++++++++++--------------
gdb/aarch64-tdep.h | 4 ----
2 files changed, 15 insertions(+), 18 deletions(-)
diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c
index 92d1248..6f52c8c 100644
--- a/gdb/aarch64-linux-tdep.c
+++ b/gdb/aarch64-linux-tdep.c
@@ -240,6 +240,18 @@ supply_fpregset_from_core (const struct regset *regset,
aarch64_linux_supply_fpregset (regcache, (const gdb_byte *) regbuf);
}
+/* Register set definitions. */
+
+static const struct regset aarch64_linux_gregset =
+ {
+ NULL, supply_gregset_from_core, NULL
+ };
+
+static const struct regset aarch64_linux_fpregset =
+ {
+ NULL, supply_fpregset_from_core, NULL
+ };
+
/* Implement the "regset_from_core_section" gdbarch method. */
static const struct regset *
@@ -247,25 +259,14 @@ aarch64_linux_regset_from_core_section (struct gdbarch *gdbarch,
const char *sect_name,
size_t sect_size)
{
- struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch);
-
if (strcmp (sect_name, ".reg") == 0
&& sect_size == AARCH64_LINUX_SIZEOF_GREGSET)
- {
- if (tdep->gregset == NULL)
- tdep->gregset = regset_alloc (gdbarch, supply_gregset_from_core,
- NULL);
- return tdep->gregset;
- }
+ return &aarch64_linux_gregset;
if (strcmp (sect_name, ".reg2") == 0
&& sect_size == AARCH64_LINUX_SIZEOF_FPREGSET)
- {
- if (tdep->fpregset == NULL)
- tdep->fpregset = regset_alloc (gdbarch, supply_fpregset_from_core,
- NULL);
- return tdep->fpregset;
- }
+ return &aarch64_linux_fpregset;
+
return NULL;
}
diff --git a/gdb/aarch64-tdep.h b/gdb/aarch64-tdep.h
index 30a5ee3..78fb779 100644
--- a/gdb/aarch64-tdep.h
+++ b/gdb/aarch64-tdep.h
@@ -82,10 +82,6 @@ struct gdbarch_tdep
/* And the size of each entry in the buf. */
size_t jb_elt_size;
- /* Cached core file helpers. */
- struct regset *gregset;
- struct regset *fpregset;
-
/* Types for AdvSISD registers. */
struct type *vnq_type;
struct type *vnd_type;
--
1.8.4.2