This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Prompt user to report bugs
- From: Doug Evans <dje at google dot com>
- To: Gary Benson <gbenson at redhat dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>, Tom Tromey <tromey at redhat dot com>
- Date: Wed, 14 May 2014 14:05:09 -0700
- Subject: Re: [PATCH] Prompt user to report bugs
- Authentication-results: sourceware.org; auth=none
- References: <20140514110742 dot GA25550 at blade dot nx>
On Wed, May 14, 2014 at 4:07 AM, Gary Benson <gbenson@redhat.com> wrote:
> Hi all,
>
> This patch prints a couple of extra lines in internal_vproblem
> to prompt the user to report the bug that's just happened.
>
> Ok to commit?
>
> Thanks,
> Gary
>
> --
> 2014-05-14 Gary Benson <gbenson@redhat.com>
>
> * utils.c (internal_vproblem): Prompt the user to file a report.
>
> diff --git a/gdb/utils.c b/gdb/utils.c
> index a8a7cb3..905ce6d 100644
> --- a/gdb/utils.c
> +++ b/gdb/utils.c
> @@ -746,6 +746,14 @@ internal_vproblem (struct internal_problem *problem,
> else
> internal_error (__FILE__, __LINE__, _("bad switch"));
>
> + fputs_unfiltered (_("\nThis is a bug, please report it."), gdb_stderr);
> + if (REPORT_BUGS_TO[0])
> + {
> + fputs_unfiltered (_(" For instructions, see:\n"), gdb_stderr);
> + fprintf_unfiltered (gdb_stderr, _("%s."), REPORT_BUGS_TO);
> + }
> + fputs_unfiltered ("\n\n", gdb_stderr);
> +
> if (problem->should_dump_core == internal_problem_ask)
> {
> if (!can_dump_core (reason))
>
top.c doesn't wrap "%s." in _().
I don't know if it matters, it's just odd to see "%s." wrapped.