This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] cplus-demangler, free resource after a failed call to gnu_special.
- From: Gary Benson <gbenson at redhat dot com>
- To: Andrew Burgess <aburgess at broadcom dot com>
- Cc: Ian Lance Taylor <iant at google dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>, Jason Merrill <jason at redhat dot com>, gdb-patches at sourceware dot org
- Date: Wed, 14 May 2014 15:20:16 +0100
- Subject: Re: [PATCH] cplus-demangler, free resource after a failed call to gnu_special.
- Authentication-results: sourceware.org; auth=none
- References: <1399646123-9960-1-git-send-email-aburgess at broadcom dot com> <CAKOQZ8zCbzpkwR_HkraUsNoDHEPt2pUXsQEk8kf_Mc43DGTHJw at mail dot gmail dot com> <536E7A72 dot 1040203 at broadcom dot com> <CAKOQZ8wBvHe6KdWDuipPmSu=6hrJZ88xDHMyP_B2sHc-4L3qNg at mail dot gmail dot com> <20140514090125 dot GA4974 at blade dot nx> <537337AF dot 3020806 at broadcom dot com>
Andrew Burgess wrote:
> On 14/05/2014 10:01 AM, Gary Benson wrote:
> > Ian Lance Taylor wrote:
> > > Andrew Burgess <aburgess@broadcom.com> wrote:
> > > > On 09/05/2014 9:53 PM, Ian Lance Taylor wrote:
> > > > > Andrew Burgess <aburgess@broadcom.com> wrote:
> > > > > > if ((AUTO_DEMANGLING || GNU_DEMANGLING))
> > > > > > {
> > > > > > success = gnu_special (work, &mangled, &decl);
> > > > > > + if (!success)
> > > > > > + {
> > > > > > + delete_work_stuff (work);
> > > > > > + string_delete (&decl);
> > > > > > + }
> > > > >
> > >
> > > This patch is OK.
> >
> > Andrew, would you like me to commit this?
>
> Yes please.
Done:
https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=210425
Thanks,
Gary
--
http://gbenson.net/