This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v5] Exit code of exited inferiors in -list-thread-groups
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Simon Marchi <simon dot marchi at ericsson dot com>
- Cc: gdb-patches at sourceware dot org, simon dot marchi at ericsson dot com
- Date: Wed, 14 May 2014 05:51:39 +0300
- Subject: Re: [PATCH v5] Exit code of exited inferiors in -list-thread-groups
- Authentication-results: sourceware.org; auth=none
- References: <1400018204-29559-1-git-send-email-simon dot marchi at ericsson dot com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: Simon Marchi <simon.marchi@ericsson.com>
> CC: Simon Marchi <simon.marchi@ericsson.com>
> Date: Tue, 13 May 2014 17:56:44 -0400
>
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -108,6 +108,11 @@ PowerPC64 GNU/Linux little-endian powerpc64le-*-linux*
> and "assf"), have been deprecated. Use the "sharedlibrary" command, or
> its alias "share", instead.
>
> +* MI changes
> +
> + ** The -list-thread-groups command outputs an exit-code field for
> + inferiors that have exited.
> +
> *** Changes in GDB 7.7
This part is OK.
> +@item exit-code
> +The exit code of this thread group when it last exited. This field is
> +only present for thread groups of type @samp{process} and only if the
> +process is not running.
This is backwards, and the 1st sentence is confusing until you read
the second one. I suggest to reword like this:
If this thread group is a @samp{process} that exited, this field is
the exit code of that inferior process. Otherwise, the field is not
present.
The documentation part is OK with this change.