This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCHv5] aarch64: detect atomic sequences like other ll/sc architectures
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Kyle McMartin <kmcmarti at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 7 May 2014 09:46:11 -0700
- Subject: Re: [PATCHv5] aarch64: detect atomic sequences like other ll/sc architectures
- Authentication-results: sourceware.org; auth=none
- References: <20140424183510 dot GI7588 at redacted dot bos dot redhat dot com> <20140430160450 dot GE2148 at redacted dot bos dot redhat dot com> <20140507135217 dot GC4063 at adacore dot com> <20140507151022 dot GQ674 at redacted dot bos dot redhat dot com>
> > AndrewP said that the code is always LE, so why not just use
> > BFD_ENDIAN_LITTLE in this case, rather than go through
> > byte_order_for_code?
> >
>
> Seemed sensible to do what aarch64_analyze_prologue did, rather than
> hard code it... I'm happy one way or another though.
Hmmm, true. It doesn't matter all that much, I think, and yours has
indeed the advantate of consistency. I pushed your patch.
For future submissions, may I make a request? Would you mind including
the revision log as part of the email when sending your patches? I went
through all versions of the patch that were sent, and couldn't find
a description of the problem. We try to have those in the revision log
to avoid having to re-locate the patches in the mailing-list when
searching for the reasons behind the patch. The nice side-effect of
following this approach is that submitting the patch is just a matter
of "git send-email"-ing it, and for me, pushing the patch is just
a matter of "git am" + "git push" (with a possible update to add
the ChangeLog entries).
Thanks again!
--
Joel