This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix prologue analysis for ldr.w and ldrd instruction

From: Luis Machado <lgustavo at codesourcery dot com>
To: tmirza <tmirza at codesourcery dot com>, Joel Brobecker <brobecker at adacore dot com>
Cc: Will Newton <will dot newton at linaro dot org>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
Date: Wed, 07 May 2014 12:41:43 -0300
Subject: Re: [PATCH] Fix prologue analysis for ldr.w and ldrd instruction
Authentication-results: sourceware.org; auth=none
References: <1399448485-1740-1-git-send-email-tmirza at codesourcery dot com> <CANu=DmgMWP=dr=9xxQxcnFC-99M-BjdZa9JQa8vHM_w8Ythkxg at mail dot gmail dot com> <20140507132511 dot GB4063 at adacore dot com> <536A5254 dot 3030402 at codesourcery dot com>
Reply-to: lgustavo at codesourcery dot com

Joel,

On 05/07/2014 12:33 PM, tmirza wrote:

On 05/07/2014 06:25 PM, Joel Brobecker wrote:

2014-05-06  Taimoor Mirza  <tmirza@codesourcery.com>

         gdb/
         * arm-tdep.c (thumb_analyze_prologue): Fix offset
calculation for
         ldr.w and ldrd instructions.

[...]

This looks good to me, assuming the testsuite was run with no
regressions.

Thanks for the review Will. Yes I ran testsuites.

Thanks, Will, for reviewing the patch. I concur on both counts:
patch is approved, but can you please also confirm how the patch
was tested?

I ran testsuites before and after applying my patch and did not find any
regression.


Thank you,

Just for the sake of completeness, the patch was tested against realboards and a simulator.


Luis

References:
- [PATCH] Fix prologue analysis for ldr.w and ldrd instruction
  - From: Taimoor Mirza
- Re: [PATCH] Fix prologue analysis for ldr.w and ldrd instruction
  - From: Will Newton
- Re: [PATCH] Fix prologue analysis for ldr.w and ldrd instruction
  - From: Joel Brobecker
- Re: [PATCH] Fix prologue analysis for ldr.w and ldrd instruction
  - From: tmirza

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]