This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/2] Fix PR breakpoints/16889: gdb segfaults when printing ASM SDT arguments
- From: Pedro Alves <palves at redhat dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>
- Date: Fri, 02 May 2014 19:56:26 +0100
- Subject: Re: [PATCH 1/2] Fix PR breakpoints/16889: gdb segfaults when printing ASM SDT arguments
- Authentication-results: sourceware.org; auth=none
- References: <1398981131-11720-1-git-send-email-sergiodj at redhat dot com> <1398981131-11720-2-git-send-email-sergiodj at redhat dot com> <53636901 dot 9090601 at redhat dot com> <m3lhuk40pm dot fsf at redhat dot com> <m3oazg2gys dot fsf at redhat dot com>
On 05/02/2014 07:06 PM, Sergio Durigan Junior wrote:
> On Friday, May 02 2014, I wrote:
>
>> Here's what I am going to push by the end of the day if there are no
>> other comments.
>
> Pedro brought something else to my attention: the testcase messages were
> not unique, and I could rewrite it in order to make it more
> automatized. So here is the third version that I will push if there are
> no other comments.
Thanks! Looks great.
FYI, with {} instead of [list ...] one can avoid the backslashes.
That is, one can write:
foreach probe_name {foo bar foo_prefix bar_prefix} \
probe_val {42 42 42 42} \
probe_reg_val {"$rsp" "$rbp - 8" "$rsp" "$rbp - 8"} {
instead of:
foreach probe_name [list "foo" "bar" "foo_prefix" "bar_prefix"] \
probe_val [list "42" "42" "42" "42"] \
probe_reg_val [list "\$rsp" "\$rbp - 8" "\$rsp" "\$rbp - 8"] {
with_test_prefix $probe_name {
Just a suggestion, it doesn't matter at all.
--
Pedro Alves