This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Mark some tests as XFAIL/UNSUPPORTED hidden due to GCC's omission of typedefs in inheritance.
- From: Pedro Alves <palves at redhat dot com>
- To: David Blaikie <dblaikie at gmail dot com>
- Cc: Doug Evans <dje at google dot com>, gdb-patches <gdb-patches at sourceware dot org>, keiths at redhat dot com
- Date: Thu, 01 May 2014 12:07:48 +0100
- Subject: Re: [patch] Mark some tests as XFAIL/UNSUPPORTED hidden due to GCC's omission of typedefs in inheritance.
- Authentication-results: sourceware.org; auth=none
- References: <CAENS6EuYXbEkbaiUG3DLYxJmysy_rF_VPBhb09==f_F8MExthQ at mail dot gmail dot com> <21336 dot 17090 dot 670369 dot 508165 at ruffy dot mtv dot corp dot google dot com> <CAENS6EvDSA7+GAa9kVFfQVv5DA8dcC4fDKM7m3_wQ1_mFo_FiA at mail dot gmail dot com>
re-reading this, I actually have comments now. :-)
On 04/25/2014 03:48 AM, David Blaikie wrote:
> - "Cannot reference non-static field \"i\""
> - gdb_test "print B<int>::A<int>::i" "Cannot reference non-static field \"i\""
> + if {[test_compiler_info {gcc-*-*}]} {
> + unsupported "gdb/16841"
Making this "unsupported" and skipping the actual tests means that we'll
just end up never ever again testing this against gcc, because I guarantee
you that if gcc changes, nobody will ever remember to adjust this test.
I don't think we should do that.
> Due to GCC's PR14819 these tests weren't actually testing this case -
GCC's PR14819 doesn't seem to be related. Did you mean some other bug?
Or did you mean _GDB_'s PR14819?
> GCC produces the same debug info regardless of whether there's a
> typedef used in the base specifier.
> + } else {
> + setup_kfail gdb/16841 *-*-*
> + gdb_test "print D::B<int>::i" "Cannot reference non-static field \"i\""
> + gdb_test "print D::Bint::i" "Cannot reference non-static field \"i\""
> + gdb_test "print B<int>::i" "Cannot reference non-static field \"i\""
> + setup_kfail gdb/16841 *-*-*
> + gdb_test "print D::B<int>::A<int>::i" \
> +
--
Pedro Alves