This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC 05/23] X86: Replace regset_alloc() invocations by static regset structures.
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: arnez at linux dot vnet dot ibm dot com
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 28 Apr 2014 17:33:17 +0200 (CEST)
- Subject: Re: [RFC 05/23] X86: Replace regset_alloc() invocations by static regset structures.
- Authentication-results: sourceware.org; auth=none
- References: <87eh0h6bkq dot fsf at br87z6lw dot de dot ibm dot com> <87ppk14wh4 dot fsf at br87z6lw dot de dot ibm dot com>
> From: Andreas Arnez <arnez@linux.vnet.ibm.com>
> Date: Mon, 28 Apr 2014 11:47:03 +0200
>
> diff --git a/gdb/amd64obsd-tdep.c b/gdb/amd64obsd-tdep.c
> index c5ed731..e7041c9 100644
> --- a/gdb/amd64obsd-tdep.c
> +++ b/gdb/amd64obsd-tdep.c
> @@ -49,11 +49,17 @@ amd64obsd_supply_regset (const struct regset *regset,
>
> gdb_assert (len >= tdep->sizeof_gregset + I387_SIZEOF_FXSAVE);
>
> - i386_supply_gregset (regset, regcache, regnum, regs, tdep->sizeof_gregset);
> + i386_gregset.supply_regset (regset, regcache, regnum, regs,
> + tdep->sizeof_gregset);
I'm not too happy with the additional level of indirection you're
introducing here. Don't particularly see the need to do this...