This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 8/9] Remove useless Guile SMOB marking functions
- From: Doug Evans <xdje42 at gmail dot com>
- To: Andy Wingo <wingo at igalia dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sat, 26 Apr 2014 17:38:24 -0700
- Subject: Re: [PATCH v2 8/9] Remove useless Guile SMOB marking functions
- Authentication-results: sourceware.org; auth=none
- References: <1397731588-23750-1-git-send-email-wingo at igalia dot com> <1397731588-23750-9-git-send-email-wingo at igalia dot com>
Andy Wingo <wingo@igalia.com> writes:
> gdb/ChangeLog:
> * guile/scm-breakpoint.c (bpscm_mark_breakpoint_smob):
> * guile/scm-exception.c (exscm_mark_exception_smob):
> * guile/scm-iterator.c (itscm_mark_iterator_smob):
> * guile/scm-objfile.c (ofscm_mark_objfile_smob):
> * guile/scm-pretty-print.c (ppscm_mark_pretty_printer_smob)
> (ppscm_mark_pretty_printer_worker_smob):
> * guile/scm-symtab.c (stscm_mark_sal_smob):
> * guile/scm-type.c (tyscm_mark_field_smob):
> * guile/scm-value.c (vlscm_mark_value_smob): Remove useless SMOB
> mark functions -- the SMOB data for all of these is allocated
> using scm_gc_malloc, so it is automatically marked.
Comments explaining "why things are the way they are" belong in code and
related docs, not changelog entries.
Instead of explaining why mark functions aren't needed in the changelog
entry, can you add some text to gdb/guile/README?
Thanks!