This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] [gdb/testsuite] include a use of the definition of a type to cause clang to emit debug info
- From: Doug Evans <dje at google dot com>
- To: David Blaikie <dblaikie at gmail dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Wed, 23 Apr 2014 16:04:26 -0700
- Subject: Re: [patch] [gdb/testsuite] include a use of the definition of a type to cause clang to emit debug info
- Authentication-results: sourceware.org; auth=none
- References: <CAENS6EvK8+AUQrj_0q2vAz0JH-5Pt0Z=cRWtW--4pyyUTP3WfQ at mail dot gmail dot com> <CAENS6EuydtwiGdk5EK7USRLphkz_0nHG-E+KtWJjC57jDAHehA at mail dot gmail dot com>
David Blaikie writes:
> commit 24a8810a97155710d3c53b401eb8729bc4f80c00
> Author: David Blaikie <dblaikie@gmail.com>
> Date: Sun Apr 13 00:48:45 2014 -0700
>
> Return by value to coax Clang into emitting the full definition of a test type.
>
> gdb/testsuite/
> * gdb.cp/pr10728-x.cc: Return by value instead of pointer to coax
> Clang into emitting the definition of the type.
> * gdb.cp/pr10728-x.h: Ditto.
> * gdb.cp/pr10728-y.cc: Ditto.
LGTM with one nit.
ChangeLog conventions require one to document the function
in which the change went.
There's plenty of existing boilerplate to copy from.
Thanks!