This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Remove unused variable
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>
- Date: Mon, 21 Apr 2014 12:54:58 -0400
- Subject: Re: [PATCH] Remove unused variable
- Authentication-results: sourceware.org; auth=none
- References: <53553E27 dot 6060009 at ericsson dot com> <20140421161232 dot GF4477 at adacore dot com>
On 14-04-21 12:12 PM, Joel Brobecker wrote:
> Simon,
>
>> should_resume is set to 1 at the beginning and never changed.
>>
>> The legal paperwork for people at Ericsson Montreal has been completed
>> last week, so I would be ready to open an account to be able to submit
>> patches.
>
> Great!
>
>>
>> gdb/ChangeLog:
>>
>> 2014-04-21 Simon Marchi <simon.marchi@ericsson.com>
>>
>> * infrun.c (resume): Remove should_resume (unused).
>
> Unfortunately, your patch does much much much much much much much
> more than just removing "should_resume" :-).
>
> Can you please submit a patch that just removes that variable?
I was afraid it would not be clear and I almost mentioned it in my
original message. There are a lot of +/- for a tiny change, because the
code looked like that:
int should_resume = 1;
/* Untouched stuff */
if (should_resume)
{
/* Lots of stuff that needs to be unindented. */
...
}
The part that was unindented by four spaces generates a lot of +/-, but
I didn't change anything else than that, I swear !
Simon