This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] Remove unnecessary argument METHOD to valops.c:oload_method_static
- From: Siva Chandra <sivachandra at google dot com>
- To: Doug Evans <dje at google dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Fri, 18 Apr 2014 18:03:12 -0700
- Subject: Re: [RFC] Remove unnecessary argument METHOD to valops.c:oload_method_static
- Authentication-results: sourceware.org; auth=none
- References: <CAGyQ6gyk89kdPXB5-=njML_gbxiJw=HAKGXBu1D1NWYj7x6sWg at mail dot gmail dot com> <CADPb22SVchdMDbus5XQPYGYuEhRSG7O0e6vOY-KhoiV6-H22NQ at mail dot gmail dot com>
On Thu, Apr 17, 2014 at 10:33 AM, Doug Evans <dje@google.com> wrote:
>> ChangeLog
>>
>> * valops.c (oload_method_static): Remove unnecessary argument
>> METHOD.
>> (find_overload_match): Update call to oload_method_static.
>> (find_oload_champ): Likewise.
>
> Hi.
> Catching up on some patch review.
> [debug methods is next!]
>
> LGTM.
> I also really like renaming oload_method_static to oload_method_static_p.
> Feel free to add that to this patch if you want.
Pushed after adding the _p suffix: 2bca57bacc88e4d81fd92c72f1d4eb42c1372ac8