This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] [testsuite] Set target-charset to ascii
- From: Doug Evans <dje at google dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: Joel Brobecker <brobecker at adacore dot com>, gdb-patches <gdb-patches at sourceware dot org>
- Date: Thu, 17 Apr 2014 10:18:48 -0700
- Subject: Re: [PATCH] [testsuite] Set target-charset to ascii
- Authentication-results: sourceware.org; auth=none
- References: <1395711550-29273-1-git-send-email-yao at codesourcery dot com> <533A23CE dot 8040905 at codesourcery dot com> <534607F5 dot 5010105 at codesourcery dot com> <20140410130700 dot GJ4250 at adacore dot com> <534F3E82 dot 3050907 at codesourcery dot com>
On Wed, Apr 16, 2014 at 7:37 PM, Yao Qi <yao@codesourcery.com> wrote:
> On 04/10/2014 09:07 PM, Joel Brobecker wrote:
>> On the other hand, a GDB built with libiconv supports ASCII (and much
>> more). So I'm inclined to try your patch. Give it another couple of
>> days, and if noone objects, then go ahead and commit.
>
> Patch is pushed in. Please shout if it causes troubles on some targets.
Hi.
No objections per se, but I'm inclined to think we should make ASCII
the default for every test (or some similar charset) (i.e., set it
where we set width to zero), and require tests that wish a different
charset to explicitly request it.