This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] constify value_aggregate_elt
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 28 Mar 2014 06:19:59 -0700
- Subject: Re: [PATCH] constify value_aggregate_elt
- Authentication-results: sourceware.org; auth=none
- References: <1395951100-8142-1-git-send-email-tromey at redhat dot com>
Hey Tom,
On Thu, Mar 27, 2014 at 02:11:40PM -0600, Tom Tromey wrote:
> While working on another patch I realized that value_aggregate_elt's
> "name" parameter ought to be const. This patch implements this.
>
> 2014-03-27 Tom Tromey <tromey@redhat.com>
>
> * valops.c (value_aggregate_elt, value_struct_elt_for_reference)
> (value_namespace_elt, value_maybe_namespace_elt): Make "name"
> const.
> * value.h (value_aggregate_elt): Update.
Any reason for delaying the push on these types of patches?
I think constifications are geneally a good thing and that
there is no real incentive into holding them before pushing...
Thanks!
> ---
> gdb/ChangeLog | 7 +++++++
> gdb/valops.c | 14 +++++++-------
> gdb/value.h | 2 +-
> 3 files changed, 15 insertions(+), 8 deletions(-)
>
> diff --git a/gdb/valops.c b/gdb/valops.c
> index cf195a3..a10dbd6 100644
> --- a/gdb/valops.c
> +++ b/gdb/valops.c
> @@ -83,15 +83,15 @@ oload_classification classify_oload_match (struct badness_vector *,
>
> static struct value *value_struct_elt_for_reference (struct type *,
> int, struct type *,
> - char *,
> + const char *,
> struct type *,
> int, enum noside);
>
> static struct value *value_namespace_elt (const struct type *,
> - char *, int , enum noside);
> + const char *, int , enum noside);
>
> static struct value *value_maybe_namespace_elt (const struct type *,
> - char *, int,
> + const char *, int,
> enum noside);
>
> static CORE_ADDR allocate_space_in_inferior (int);
> @@ -3014,7 +3014,7 @@ destructor_name_p (const char *name, struct type *type)
> the comment before value_struct_elt_for_reference. */
>
> struct value *
> -value_aggregate_elt (struct type *curtype, char *name,
> +value_aggregate_elt (struct type *curtype, const char *name,
> struct type *expect_type, int want_address,
> enum noside noside)
> {
> @@ -3095,7 +3095,7 @@ compare_parameters (struct type *t1, struct type *t2, int skip_artificial)
>
> static struct value *
> value_struct_elt_for_reference (struct type *domain, int offset,
> - struct type *curtype, char *name,
> + struct type *curtype, const char *name,
> struct type *intype,
> int want_address,
> enum noside noside)
> @@ -3324,7 +3324,7 @@ value_struct_elt_for_reference (struct type *domain, int offset,
>
> static struct value *
> value_namespace_elt (const struct type *curtype,
> - char *name, int want_address,
> + const char *name, int want_address,
> enum noside noside)
> {
> struct value *retval = value_maybe_namespace_elt (curtype, name,
> @@ -3346,7 +3346,7 @@ value_namespace_elt (const struct type *curtype,
>
> static struct value *
> value_maybe_namespace_elt (const struct type *curtype,
> - char *name, int want_address,
> + const char *name, int want_address,
> enum noside noside)
> {
> const char *namespace_name = TYPE_TAG_NAME (curtype);
> diff --git a/gdb/value.h b/gdb/value.h
> index f846669..9425a0e 100644
> --- a/gdb/value.h
> +++ b/gdb/value.h
> @@ -676,7 +676,7 @@ extern struct value *value_struct_elt_bitpos (struct value **argp,
> const char *err);
>
> extern struct value *value_aggregate_elt (struct type *curtype,
> - char *name,
> + const char *name,
> struct type *expect_type,
> int want_address,
> enum noside noside);
> --
> 1.8.5.3
--
Joel