This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCHv2] aarch64: detect atomic sequences like other ll/sc architectures
- From: Marcus Shawcroft <marcus dot shawcroft at gmail dot com>
- To: Kyle McMartin <kmcmarti at redhat dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Thu, 27 Mar 2014 16:12:55 +0000
- Subject: Re: [PATCHv2] aarch64: detect atomic sequences like other ll/sc architectures
- Authentication-results: sourceware.org; auth=none
- References: <20140327015125 dot GE3075 at redacted dot bos dot redhat dot com> <CAFqB+Px4rL39pOqA8vxKOC7BDxRCUq8TTCixyk+aRoJ8MnNmMg at mail dot gmail dot com> <20140327154033 dot GI3075 at redacted dot bos dot redhat dot com>
On 27 March 2014 15:40, Kyle McMartin <kmcmarti@redhat.com> wrote:
> On Thu, Mar 27, 2014 at 02:07:35PM +0000, Marcus Shawcroft wrote:
>> Are you sure these masks and patterns are accurate? Looks to me that
>> this excludes many of the load exclusive instructions and includes
>> part of the unallocated encoding space. There are several different
>> encodings to match here covering ld[a]xr{b,h,} and ld[a]xp. The masks
>> and patterns will be something like:
>>
>> 0xbfff7c00 0x085f7c00
>> 0xbfff7c00 0x885f7c00
>> 0xbfff0000 0x887f0000
>>
>> > + if (decode_masked_match (insn, 0x3fc00000, 0x08000000))
>>
>> This also looks wrong.
>>
>
> Eh... I tested all 24 possible ldxr/stxr opcodes...
Kyle
You are right, sorry, I can't read the encoding tables. This mask and
pattern is indeed sensible.
Cheers
/Marcus