This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] aarch64: detect atomic sequences like other ll/sc architectures
- From: Kyle McMartin <kmcmarti at redhat dot com>
- To: Richard Earnshaw <rearnsha at arm dot com>
- Cc: Joel Brobecker <brobecker at adacore dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Wed, 26 Mar 2014 21:52:14 -0400
- Subject: Re: [PATCH] aarch64: detect atomic sequences like other ll/sc architectures
- Authentication-results: sourceware.org; auth=none
- References: <20140324161056 dot GB23291 at redacted dot bos dot redhat dot com> <20140324165733 dot GN4282 at adacore dot com> <533072CF dot 3050702 at arm dot com>
On Mon, Mar 24, 2014 at 06:00:47PM +0000, Richard Earnshaw wrote:
> On 24/03/14 16:57, Joel Brobecker wrote:
> > Hello Kyle,
> >> + /* look for a conditional branch to set a breakpoint on the destination. */
> >
> > This line looks too long?
>
> Also, comments are full sentences, so begin with a capital letter and
> end with a full stop and two spaces.
>
> >> + /* and the matching store-exclusive to close it. */
> >> + if (decode_masked_match(insn, 0x3fc00000, 0x08000000))
> >
> > Same here...
>
> If you really need a continuation comment like this, then end the
> previous one with "..." and start the current one with "... and".
> Otherwise, this should be re-written as a stand-alone sentence.
>
Thanks very much, I've just posted a v2 which I hope addresses your
issues with my patch (and adds a testcase.)
regards, Kyle