This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH][PR breakpoints/16606] AVR8 breakpoint out of range, decrement pc after break
- From: Pedro Alves <palves at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: Pierre Langlois <pierre dot langlois at embecosm dot com>, gdb-patches at sourceware dot org
- Date: Mon, 10 Mar 2014 17:07:29 +0000
- Subject: Re: [PATCH][PR breakpoints/16606] AVR8 breakpoint out of range, decrement pc after break
- Authentication-results: sourceware.org; auth=none
- References: <531A2316 dot 5090507 at embecosm dot com> <20140310110809 dot GC4882 at adacore dot com>
On 03/10/2014 11:08 AM, Joel Brobecker wrote:
>> @@ -1436,6 +1439,7 @@ avr_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
>> set_gdbarch_inner_than (gdbarch, core_addr_lessthan);
>>
>> set_gdbarch_breakpoint_from_pc (gdbarch, avr_breakpoint_from_pc);
>> + set_gdbarch_decr_pc_after_break (gdbarch, 2);
>
> This part seems fine, but it would be good if you could submit it
> separately, with an explanation of the problem you are seeing
> (a copy of the gdb debugging session is often useful).
Yes please. I'm quite mystified that only 'b *0xaddr' exposed the need
for this. If PC adjustment is really necessary on this architecture,
then I can't imagine how the port managed to be functional thus
far without this.
--
Pedro Alves