This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/6] PR breakpoints/7143 - Watchpoint does not trigger when first set
- From: Pedro Alves <palves at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Wed, 05 Mar 2014 15:35:53 +0000
- Subject: Re: [PATCH 2/6] PR breakpoints/7143 - Watchpoint does not trigger when first set
- Authentication-results: sourceware.org; auth=none
- References: <1393360363-5603-1-git-send-email-palves at redhat dot com> <1393360363-5603-3-git-send-email-palves at redhat dot com>
On 02/25/2014 08:32 PM, Pedro Alves wrote:
> + if (ecs->event_thread->stepping_over_breakpoint
> + && !use_displaced_stepping (get_regcache_arch (regcache)))
> {
> - struct regcache *thread_regcache = get_thread_regcache (ecs->ptid);
> + /* Can't step over more than one breakpoint simultaneously
> + without displaced stepping. */
> + gdb_assert (step_over_aspace == NULL);
While working on further changes on top of this series, I noticed
something wrong. Then I decided to reorder the patches a little,
and add another watchpoint-related test, which then managed to
trigger this assertion, because we
- stepped a thread
- got to the thread_hop code without clearing step_over_aspace.
v2 will clear step_over_aspace earlier to avoid that. It's still
a good idea to do that even though the series ends up eliminating
the thread hop code.
--
Pedro Alves