This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/7] procfs.c: Don't install a deprecated_xfer_memory method
- From: Pedro Alves <palves at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 24 Feb 2014 18:20:42 +0000
- Subject: Re: [PATCH 3/7] procfs.c: Don't install a deprecated_xfer_memory method
- Authentication-results: sourceware.org; auth=none
- References: <1392841775-19126-1-git-send-email-palves at redhat dot com> <1392841775-19126-4-git-send-email-palves at redhat dot com> <20140220154826 dot GD4113 at adacore dot com> <20140220155611 dot GA17210 at adacore dot com> <53062F86 dot 6020409 at redhat dot com> <20140224175346 dot GB4154 at adacore dot com>
On 02/24/2014 05:53 PM, Joel Brobecker wrote:
>>>>> 2014-02-19 Pedro Alves <palves@redhat.com>
>>>>>
>>>>> * procfs.c (procfs_target): Don't install procfs_xfer_memory as
>>>>> deprecated_xfer_memory hook.
>>>>> (procfs_xfer_partial): Call procfs_xfer_memory instead
>>>>> of the deprecated_xfer_memory target hook.
>>>>> (procfs_xfer_memory): Adjust interface as a to_xfer_partial
>>>>> helper.
>>>>
>>>> FYI: I tried to test it, but the sparc-solaris debugger appears to be
>>>> badly broken at the moment, and I won't have much time left this week
>>>> to investigate the failures, so I'll schedule that for next week.
>
> It turns out that your patch fixes the breakage as a side-effect.
> Since it's bad breakage, I pushed the patch immediately, after having
> updated the revision log:
Eh, cool, thanks!
--
Pedro Alves