This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Hi! On Mon, 17 Feb 2014 11:34:08 +0800, Yao Qi <yao@codesourcery.com> wrote: > A recent change (commit 3398af6aa352b0611bc9d66aed72080a876e42d4) > in gnu-nat.c causes the some missing-prototypes warnings, > > ../../../git/gdb/gnu-nat.c:1864:1: error: no previous prototype for 'S_proc_pid2task_reply' [-Werror=missing-prototypes] > ../../../git/gdb/gnu-nat.c:1866:1: error: no previous prototype for 'S_proc_task2pid_reply' [-Werror=missing-prototypes] > ../../../git/gdb/gnu-nat.c:1868:1: error: no previous prototype for 'S_proc_task2proc_reply' [-Werror=missing-prototypes] > > A new macro ILL_RPC was added, which defines some external > functions. However, they are not declared and GCC complains about this. Ha, so I wondered why did you see this error, and I did not when testing my patch, commit 3398af6aa352b0611bc9d66aed72080a876e42d4? Next I wondered, why missing prototypes only for these three functions? This lead to the answer: depending on which RPCs are defined on the Mach or Hurd side, MIG will generate different sets of stub functions (and respective prototypes in the *_S.h header file). We recently added some new RPCs to the Hurd, and I also added the respective stubs to GDB in my recent patch -- in my build, the prototypes come from the *_S.h header file, but not in yours, as you're using a toolchain that does not define these RPCs (no worries, they're of no use for GDB). > This patch is to add the declarations of these external function in > macro ILL_RPC. Pushed it as obvious. > * gnu-nat.c (ILL_RPC): Declare defined function. > --- a/gdb/gnu-nat.c > +++ b/gdb/gnu-nat.c > @@ -1783,6 +1783,7 @@ do_mach_notify_dead_name (mach_port_t notify, mach_port_t dead_port) > > > #define ILL_RPC(fun, ...) \ > + extern kern_return_t fun (__VA_ARGS__); \ > kern_return_t fun (__VA_ARGS__) \ > { \ > warning (_("illegal rpc: %s"), #fun); \ Yes, this looks fine, thanks! GrÃÃe, Thomas
Attachment:
pgp2gmSkvmnXN.pgp
Description: PGP signature
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |