Re: [PATCH] cleanup: remove declared variables without any references

[Joel Brobecker <brobecker at adacore dot com>]

Hello Sanimir,

Thanks for sending the patches!

As you can see, bunching the changes together is causing a little
extra work, now, because multiple reviews end up being involved,
and we end up having to keep track of what was already reviewed,
and what has not.

I know it's a lot of files, but all these changes should be mostly
independent, so we could go one file at a time, a few files each day.
When we've finished reviewing the a batch, just send another. WDYT?

> 
> The mipsnbsd-tdep.c one is not ok.  For one thing, you're leaving
> behind the comment describing the code.  But I think this is better
> left alone, as somebody might want to add (or put back) the missing
> glue that uses those bits.

Hey Mark! The problem with leaving them behind is that they cause
a build failure when building the HEAD, I think, because we build
with -Werror. Can we find a way to avoid that? For instance, could
we #if zero the code?

> > 2014-02-11  Sanimir Agovic  <sanimir.agovic@intel.com>
> > 
> > 	* cris-tdep.c (cris_supply_gregset): Remove zerobuf.
> > 	(_initialize_cris_tdep): Remove cris_set_cmdlist, cris_show_cmdlist.
> > 	* h8300-tdep.c (setmachinelist): Remove global.
> > 	* hppa-tdep.c (hppa_sigtramp): Remove global.
> > 	* ia64-tdep.c (fp_regnum, lr_regnum): Remove globals.
> > 	* mipsnbsd-tdep.c (sigtramp_retcode_mipsel, sigtramp_retcode_mipseb):
> > 	Remove globals.
> > 	* ravenscar-thread.c (update_target_observer): Remove global.
> > 	* rs6000-tdep.c (rs6000_gdbarch_init): Remove segment_regs.
> > 	* symfile-debug.c (debug_sym_fns): Remove global.

The h8300-tdep.c, ravenscar-thread.c changes are OK.

the ia64-tdep.c is officially Jan's jurisdiction, but the change looks
OK to me. If he doesn't object by, say, end of this week, please apply
the change (Jan: I'll revert immediately if you object).

The rs6000-tdep.c change is OK. It looks like it was already
unused when it was introduced, and I think it was an unintentional
left over from the development phase where the table was first
defined at one location, and then later moved to a different location
(init_sim_regno_table). See commit:

    commit 7cc46491b1832408d1d5472e3f0c17c8a1d78ccb
    Date:   Mon Oct 15 19:45:31 2007 +0000

This leaves symfile-debug.c, for which I don't know.

-- 
Joel