This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [OB PATCH] Update debug_qf_expand_symtabs_matching to use typedefs
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Gary Benson <gbenson at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 11 Feb 2014 07:45:11 +0400
- Subject: Re: [OB PATCH] Update debug_qf_expand_symtabs_matching to use typedefs
- Authentication-results: sourceware.org; auth=none
- References: <20140210145635 dot GA30479 at blade dot nx>
Hi Gary,
> 2014-02-10 Gary Benson <gbenson@redhat.com>
>
> * symfile-debug.c (debug_qf_expand_symtabs_matching):
> Use expand_symtabs_file_matcher_ftype and
> expand_symtabs_symbol_matcher_ftype.
> Rename name_matcher to symbol_matcher.
Thanks for the patch. I noticed that the formatting looked odd, and
indeed, it looks like you reduced the parameter's indentation in order
to make each parameter fit in 80 columns.
> static void
> debug_qf_expand_symtabs_matching (struct objfile *objfile,
> - int (*file_matcher) (const char *, void *,
> - int basenames),
> - int (*name_matcher) (const char *, void *),
> + expand_symtabs_file_matcher_ftype *file_matcher,
> + expand_symtabs_symbol_matcher_ftype *symbol_matcher,
We use a different formatting strategy in this case. Attached is the
patch I just checked in.
gdb/ChangeLog:
* symfile-debug.c (debug_qf_expand_symtabs_matching): Reformat
function parameters.
--
Joel
>From e86b67d3a13e6f63c68145105b6aba3b867f94cc Mon Sep 17 00:00:00 2001
From: Joel Brobecker <brobecker@adacore.com>
Date: Tue, 11 Feb 2014 07:31:26 +0400
Subject: [PATCH] Reformat symfile-debug.c::debug_qf_expand_symtabs_matching
parameters.
gdb/ChangeLog:
* symfile-debug.c (debug_qf_expand_symtabs_matching): Reformat
function parameters.
---
gdb/ChangeLog | 5 +++++
gdb/symfile-debug.c | 10 +++++-----
2 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 4487b6b..72b41e4 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2014-02-11 Joel Brobecker <brobecker@adacore.com>
+
+ * symfile-debug.c (debug_qf_expand_symtabs_matching): Reformat
+ function parameters.
+
2014-02-10 Will Newton <will.newton@linaro.org>
* elfread.c (elf_rel_plt_read): Look for a .got section if
diff --git a/gdb/symfile-debug.c b/gdb/symfile-debug.c
index e0a5011..c247bd7 100644
--- a/gdb/symfile-debug.c
+++ b/gdb/symfile-debug.c
@@ -283,11 +283,11 @@ debug_qf_map_matching_symbols (struct objfile *objfile,
}
static void
-debug_qf_expand_symtabs_matching (struct objfile *objfile,
- expand_symtabs_file_matcher_ftype *file_matcher,
- expand_symtabs_symbol_matcher_ftype *symbol_matcher,
- enum search_domain kind,
- void *data)
+debug_qf_expand_symtabs_matching
+ (struct objfile *objfile,
+ expand_symtabs_file_matcher_ftype *file_matcher,
+ expand_symtabs_symbol_matcher_ftype *symbol_matcher,
+ enum search_domain kind, void *data)
{
const struct debug_sym_fns_data *debug_data =
objfile_data (objfile, symfile_debug_objfile_data_key);
--
1.8.3.2