This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 01/36] Guile extension language: configure changes
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Doug Evans <xdje42 at gmail dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 10 Feb 2014 14:23:42 +0400
- Subject: Re: [PATCH v2 01/36] Guile extension language: configure changes
- Authentication-results: sourceware.org; auth=none
- References: <52dd9a9a dot 488b440a dot 4678 dot 03e6 at mx dot google dot com> <m3y51j8r62 dot fsf at sspiff dot org>
Hi Doug,
> +AC_PATH_PROG(pkg_config_prog_path, pkg-config, missing)
[...]
> +AC_DEFUN([AC_TRY_LIBGUILE],
> +[
> + pkg_config=$1
> + guile_version_list=$2
> + flag_errors=$3
> + define([have_libguile_var],$4)
> + if test "${pkg_config}" = "missing"; then
> + AC_ERROR(pkg-config program not found)
> + fi
> + if test ! -f "${pkg_config}"; then
> + AC_ERROR(pkg-config program ${pkg_config} not found)
> + fi
I don't think we should error if pkg-config was not found and --with-guile
was left to "auto". This is going to break the build of many of us
who work on systems that don't have that tool installed (I've just
noticed that on Windows). Intead, let's disable guile support
when that happens.
For the second error, I think we should apply the same principle.
Can you adjust that part, please?
Thank you,
--
Joel