This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 09/11] ELFv2 ABI: stack frame layout changes
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Ulrich Weigand <uweigand at de dot ibm dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 29 Jan 2014 08:47:07 +0400
- Subject: Re: [PATCH 09/11] ELFv2 ABI: stack frame layout changes
- Authentication-results: sourceware.org; auth=none
- References: <201401281730 dot s0SHUDiY023019 at d06av02 dot portsmouth dot uk dot ibm dot com>
My only comment is that the ChangeLog is missing :)
> Index: binutils-gdb/gdb/ppc-sysv-tdep.c
> ===================================================================
> --- binutils-gdb.orig/gdb/ppc-sysv-tdep.c
> +++ binutils-gdb/gdb/ppc-sysv-tdep.c
> @@ -1470,9 +1470,13 @@ ppc64_sysv_abi_push_dummy_call (struct g
> argpos.regcache = regcache;
> argpos.refparam = align_down (sp - refparam_size, 16);
> argpos.gparam = align_down (argpos.refparam - gparam_size, 16);
> - /* Add in space for the TOC, link editor double word,
> - compiler double word, LR save area, CR save area. */
> - sp = align_down (argpos.gparam - 48, 16);
> + /* Add in space for the TOC, link editor double word (v1 only),
> + compiler double word (v1 only), LR save area, CR save area,
> + and backchain. */
> + if (tdep->elf_abi == POWERPC_ELF_V1)
> + sp = align_down (argpos.gparam - 48, 16);
> + else
> + sp = align_down (argpos.gparam - 32, 16);
> }
>
> /* If the function is returning a `struct', then there is an
> --
> Dr. Ulrich Weigand
> GNU/Linux compilers and toolchain
> Ulrich.Weigand@de.ibm.com
--
Joel