This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 01/11] Refactor ppc64 function call and return value handling

> ChangeLog:
> 	* ppc-sysv-tdep.c (get_decimal_float_return_value): Update comment.
> 	(struct ppc64_sysv_argpos): New data structure.
> 	(ppc64_sysv_abi_push_float): Remove.
> 	(ppc64_sysv_abi_push_val): New function.
> 	(ppc64_sysv_abi_push_integer): Likewise.
> 	(ppc64_sysv_abi_push_freg): Likewise.
> 	(ppc64_sysv_abi_push_vreg): Likewise.
> 	(ppc64_sysv_abi_push_param): Likewise.
> 	(ppc64_sysv_abi_push_dummy_call): Refactor to use those new routines.
> 	(ppc64_sysv_abi_return_value_base): New function.
> 	(ppc64_sysv_abi_return_value): Refactor to use it.

I like this patch a lot. It's difficult for me to track which code
went were, and make sure an unintended change slipped through, though,
but I think I see logic, and everything I checked looked fine.

My only comment is trivial in nature, but there are many areas where
the required empty line after the local variable declarations is
missing. For instance:

> -      /* Version 1.7 of the 64-bit PowerPC ELF ABI says:
> +      CORE_ADDR aligned_gparam = align_up (argpos->gparam, align);
> +      argpos->greg += (aligned_gparam - argpos->gparam) / tdep->wordsize;
> +      argpos->gparam = aligned_gparam;


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]