This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH 3/3] avoid python exception in FrameDecorator.py
- From: Tom Tromey <tromey at redhat dot com>
- To: gdb-patches at sourceware dot org
- Cc: Tom Tromey <tromey at redhat dot com>
- Date: Wed, 22 Jan 2014 08:59:59 -0700
- Subject: [PATCH 3/3] avoid python exception in FrameDecorator.py
- Authentication-results: sourceware.org; auth=none
- References: <1390406399-26664-1-git-send-email-tromey at redhat dot com>
This fixes a bug in FrameDecorator.py.
FrameVars seems to assume that Frame.block can return None if there is
no block. However, it actually throws an exception.
I saw this bug while developing a frame filter, but unfortunately I
don't know how to reproduce it. It seems to me that the SAL tests in
_is_limited_frame should exclude the bad cases; and in my attempts to
write a test they do.
Nevertheless I think the fix is reasonably obvious and ought to go in.
2014-01-22 Tom Tromey <tromey@redhat.com>
PR python/16485:
* python/lib/gdb/FrameDecorator.py: (FrameVars.fetch_frame_args):
Handle exception from frame.block.
(FrameVars.fetch_frame_locals): Likewise.
---
gdb/ChangeLog | 7 +++++++
gdb/python/lib/gdb/FrameDecorator.py | 12 ++++++++++--
2 files changed, 17 insertions(+), 2 deletions(-)
diff --git a/gdb/python/lib/gdb/FrameDecorator.py b/gdb/python/lib/gdb/FrameDecorator.py
index 1b8b4ed..1bbc5ab 100644
--- a/gdb/python/lib/gdb/FrameDecorator.py
+++ b/gdb/python/lib/gdb/FrameDecorator.py
@@ -258,7 +258,10 @@ class FrameVars(object):
are no frame local variables, return an empty list."""
lvars = []
- block = self.frame.block()
+ try:
+ block = self.frame.block()
+ except RuntimeError:
+ block = None
while block != None:
if block.is_global or block.is_static:
@@ -279,7 +282,12 @@ class FrameVars(object):
there are no frame argument variables, return an empty list."""
args = []
- block = self.frame.block()
+
+ try:
+ block = self.frame.block()
+ except RuntimeError:
+ block = None
+
while block != None:
if block.function != None:
break
--
1.8.1.4