This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/2] Add ARI (ok) marker for __func__ reference in common-utils.h
- From: Doug Evans <dje at google dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Tue, 21 Jan 2014 20:44:40 -0800
- Subject: Re: [PATCH 2/2] Add ARI (ok) marker for __func__ reference in common-utils.h
- Authentication-results: sourceware.org; auth=none
- References: <20140118015244 dot GA22787 at sourceware dot org> <1390300575-6998-1-git-send-email-brobecker at adacore dot com> <1390300575-6998-2-git-send-email-brobecker at adacore dot com>
On Tue, Jan 21, 2014 at 2:36 AM, Joel Brobecker <brobecker@adacore.com> wrote:
> Hello,
>
> The ARI script flagged the use of the __func__ variable, which
> is normally not allowed (not defined in C90). However, this particular
> use is OK, as the reference is only made when __STDC_VERSION__ >=
> 199901L. So, add an "ARI:" comment to explicitly OK this use.
>
> gdb/ChangeLog:
>
> * common/common-utils.h: Add "ARI:" comment besides __func__
> reference.
>
> OK to commit?
Fine by me.
English nit: "... comment beside __func__ reference".
I wonder though how ARI handled gdb_assert.h (where FUNCTION_NAME
originates from).