This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] fixed inherit_abstract_dies infinite recursive call
- From: Tom Tromey <tromey at redhat dot com>
- To: manjian2006 at gmail dot com
- Cc: gdb-patches at sourceware dot org, linzj <linzj at ucweb dot com>
- Date: Sun, 19 Jan 2014 22:53:39 -0700
- Subject: Re: [PATCH] fixed inherit_abstract_dies infinite recursive call
- Authentication-results: sourceware.org; auth=none
- References: <1390191898-2635-1-git-send-email-manjian2006 at gmail dot com>
>>>>> ">" == manjian2006 <manjian2006@gmail.com> writes:
>> From: linzj <linzj@ucweb.com>
>> A dwarf die may have the following relationship:
>> 564860c<-----------------------------
>> | |
>> |(abstract origin) |
>> | |
>> V |
>> 5816d55 | (abstract origin)
>> | |
>> |(child) |
>> | |
>> V |
>> ... |
>> 5812c34------------------------------
What does it mean when this happens?
It seems very strange to me, like it must be a compiler bug.
>> + /* True if this die is in process */
Comments must end with a period and two spaces.
I would write something like "True if this DIE is currently being
processed." though.
>> + /* Only process those who are not in process */
Ditto about the formatting.
>> + if(die->in_process)
Space before open paren.
I think this needs a test case.
It should be possible, I think, to write one using the DWARF assembler.
Tom