This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Add comments to gdbarch_address_class_name_to_type_flags
- From: Pedro Alves <palves at redhat dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>
- Cc: Simon Marchi <simon dot marchi at ericsson dot com>, GDB Patches <gdb-patches at sourceware dot org>
- Date: Thu, 16 Jan 2014 19:57:57 +0000
- Subject: Re: [PATCH] Add comments to gdbarch_address_class_name_to_type_flags
- Authentication-results: sourceware.org; auth=none
- References: <52D8293B dot 6060701 at ericsson dot com> <52D82EDF dot 5010402 at redhat dot com> <m3bnzbag2n dot fsf at redhat dot com> <52D8327D dot 7010403 at redhat dot com> <52D833E8 dot 8090308 at ericsson dot com> <m34n53aeyx dot fsf at redhat dot com>
On 01/16/2014 07:44 PM, Sergio Durigan Junior wrote:
> On Thursday, January 16 2014, Simon Marchi wrote:
>
>> I'm ok with that. Actually, I looked around to try to keep the same style, but I stumbled upon a "bad" example :P
>
> $ git grep "zero otherwise" | wc -l
> 85
> $ git grep "false otherwise" | wc -l
> 30
>
> Not very hard to choose a "bad" example...
Alright, you win. :-) Wishful thinking I guess.
I do think true/false is better when we mean a boolean.
We even had talks about using gnulib's bool before. Kind
of moot/unnecessary if we do get to move to C++ though.
--
Pedro Alves