This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH v4 01/13] vla: introduce new bound type abstraction adapt uses

Thanks for your review.

> -----Original Message-----
> From: Tom Tromey []
> Sent: Wednesday, January 15, 2014 10:39 PM
> To: Agovic, Sanimir
> Cc: 'Joel Brobecker';;;;
> Boell, Keven
> Subject: Re: [PATCH v4 01/13] vla: introduce new bound type abstraction adapt uses
> Joel> I think that the _1 suffix is usually used when the function performs
> Joel> the private portion of a more public routine.  But in this case,
> Joel> create_range_type_1 is meant to be a public routine, and the _1
> Joel> suffix is not very explicit.  IMO, what would be ideal would be to
> Joel> rename the current create_range_type into "create_static_range_type",
> Joel> and then make create_range_type_1 the new create_range_type. I checked
> Joel> the GDB tree, and there aren't that many calls to update. If people
> Joel> prefer, I can even take care of that myself once the patche series
> Joel> has gone in. Otherwise, another compromise solution is to rename
> Joel> create_range_type_1 to create_range_type_full (for instance).
> Sanimir> Sounds good to me. I will prepend a patch doing the
> Sanimir> create_range_type -> create_static_range_type thingy and use
> Sanimir> create_range_type in this patch instead of create_range_type_1.
> I guess this is one of the remaining blockers for this series now.
> Though since Joel was agreeable I think it would be fine if you'd prefer
> to do it as a follow-up.
I had already prepared a patch doing the necessary renaming upfront. If it is OK
to you and/or Joel I like to keep it as the first patch in my series.

Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]