This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] testsuite/gdb.dwarf2: Fix for dw2-ifort-parameter failure on ARM
- From: Pedro Alves <palves at redhat dot com>
- To: Omair Javaid <omair dot javaid at linaro dot org>
- Cc: Yao Qi <yao at codesourcery dot com>, gdb-patches at sourceware dot org
- Date: Thu, 16 Jan 2014 14:00:37 +0000
- Subject: Re: [PATCH] testsuite/gdb.dwarf2: Fix for dw2-ifort-parameter failure on ARM
- Authentication-results: sourceware.org; auth=none
- References: <CANW4E-2bQYjx6YdR3qGyKUsQa_KOrtmkWsZYqKzcuQBF==RPpw at mail dot gmail dot com> <CANW4E-25HdXYKMk258iO=GZ=PNM=Zu4jMbstpkSoMgE9wFpmkQ at mail dot gmail dot com> <51E4B587 dot 70007 at codesourcery dot com> <CANW4E-0vd51dTvd5qxUbeDn7ebXV-cf+WS4+VpyyGyD0MYGk8Q at mail dot gmail dot com> <5280A528 dot 8040308 at codesourcery dot com> <52D7A05F dot 6070304 at linaro dot org> <52D7AAF1 dot 80501 at redhat dot com> <52D7B3C5 dot 1000702 at linaro dot org> <52D7D222 dot 9020403 at redhat dot com> <52D7E4C5 dot 4040504 at linaro dot org>
On 01/16/2014 01:55 PM, Omair Javaid wrote:
>> > diff --git a/gdb/testsuite/gdb.dwarf2/dw2-ifort-parameter.c b/gdb/testsuite/gdb.dwarf2/dw2-ifort-parameter.c
>> > index 361c44d..c866b0f 100644
>> > --- a/gdb/testsuite/gdb.dwarf2/dw2-ifort-parameter.c
>> > +++ b/gdb/testsuite/gdb.dwarf2/dw2-ifort-parameter.c
>> > @@ -29,3 +29,9 @@ main (void)
>> > func ();
>> > return 0;
>> > }
>> > +
>> > +/* Addresses represented as data symbols, thus without Thumb (etc.)
>> > + mode bits. The dw2-ifort-parameter-debug.S file uses this as
>> > + func's low_pc/high_pc. */
>> > +extern void *func_addr __attribute__ ((alias ("func")));
>> > +extern void *main_addr __attribute__ ((alias ("main")));
> Patch doesnt fix the issue and builds after making changes to alias definition like:
Odd. Are you saying the patch didn't build for you? It did for
me, in Thumb mode, and the debug info I saw looked right (no
thumb bit).
> extern void func_addr() __attribute__ ((alias ("func")));
> extern void main_addr() __attribute__ ((alias ("main")));
...
> but issues remains the same.
That's expected, as the whole point was making a data symbol
(void *), but that change makes it a function again (thus
ends up with the thumb bit set again).
--
Pedro Alves