This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v4 04/13] vla: enable sizeof operator for indirection
- From: Tom Tromey <tromey at redhat dot com>
- To: Sanimir Agovic <sanimir dot agovic at intel dot com>
- Cc: palves at redhat dot com, xdje42 at gmail dot com, gdb-patches at sourceware dot org, keven dot boell at intel dot com
- Date: Wed, 15 Jan 2014 14:28:24 -0700
- Subject: Re: [PATCH v4 04/13] vla: enable sizeof operator for indirection
- Authentication-results: sourceware.org; auth=none
- References: <1387282678-3847-1-git-send-email-sanimir dot agovic at intel dot com> <1387282678-3847-5-git-send-email-sanimir dot agovic at intel dot com>
>>>>> "Sanimir" == Sanimir Agovic <sanimir.agovic@intel.com> writes:
Sanimir> 2013-10-18 Sanimir Agovic <sanimir.agovic@intel.com>
Sanimir> Keven Boell <keven.boell@intel.com>
Sanimir> * eval.c (evaluate_subexp_for_sizeof): Create a indirect value and
Sanimir> retrieve the dynamic type size.
I neglected to mention it in the previous patch, but when changing one
case in a function like this, that consists of little but a big switch,
it's normal to mention the case, like:
* eval.c (evaluate_subexp_for_sizeof) <UNOP_IND>: ...
The patch looks good.
Tom