Re: [PATCH] gdb.mi/mi-info-os.exp: Fix cross-debugger testing

[Pedro Alves <palves at redhat dot com>]

Hi guys,

Going through my local git branches I found this
one almost forgotten.  FYI, I went ahead and pushed
it in.

-- 
Pedro Alves

On 11/21/2013 11:36 AM, Pedro Alves wrote:

> But, WDYT of this alternative below?  We don't want to
> unconditionally use mi_run_to_main, as then with native targets
> we'd lose the testing of -info-os before the program is running.
> But we can do what mi_run_to_main ends up using to connect
> to the target instead (mi_gdb_target_load).
> 
> ---
> gdb.mi/mi-info-os.exp: Fix cross-debugger testing
> 
> A live target is required for `-info-os' to work in non-native
> configurations.
> 
>  (gdb)
>  Expecting: ^(-info-os[
>  ]+)?(.*\^done,OSDataTable=.*[
>  ]+[(]gdb[)]
>  [ ]*)
> - info-os
>  ^error,msg="Don't know how to get OS data.  Try \"help target\"."
>  (gdb)
>  FAIL: gdb.mi/mi-info-os.exp: -info-os
> 
> If GDB does have a native configuration included, but we're testing
> remote, it'll be worse, as if we're not connected yet, -info-os will
> run against the default run target, and pass, falsely giving the
> impression the remote bits were exercised.
> 
> gdb/testsuite/
> 2013-11-21  Maciej W. Rozycki  <macro@codesourcery.com>
> 	    Pedro Alves  <palves@redhat.com>
> 
> 	* gdb.mi/mi-info-os.exp: Connect to the target with
>         mi_gdb_target_load.
> ---
> 
>  gdb/testsuite/gdb.mi/mi-info-os.exp |   20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/gdb/testsuite/gdb.mi/mi-info-os.exp b/gdb/testsuite/gdb.mi/mi-info-os.exp
> index d410cfb..f062510 100644
> --- a/gdb/testsuite/gdb.mi/mi-info-os.exp
> +++ b/gdb/testsuite/gdb.mi/mi-info-os.exp
> @@ -33,6 +33,26 @@ if [mi_gdb_start] {
>      continue
>  }
>  
> +standard_testfile basics.c
> +
> +if [build_executable "Failed to build $testfile" $testfile $srcfile \
> +	debug] {
> +    return -1;
> +}
> +if {[mi_gdb_load $binfile] < 0} {
> +    return -1
> +}
> +# When testing a cross configuration, we need to be sure to first
> +# connect to the target.  If we didn't do that, GDB would try running
> +# the command against the default run target.  The usual way to do
> +# that and covera all target is to run to main, with mi_run_to_main.
> +# However, with native configurations, -info-os should work before
> +# running any program, so we want to avoid "run".  Using
> +# mi_gdb_target_load directly instead achieves this.
> +if {[mi_gdb_target_load] < 0} {
> +    return -1
> +}
> +
>  # Try the argument-less form that lists all the types in a table.
>  
>  mi_gdb_test "-info-os" ".*\\^done,OSDataTable=.*" "-info-os"
>