This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] Change coding style rule: 80 column "hard limit" for ChangeLogs

On Wed, Jan 8, 2014 at 3:45 AM, Joel Brobecker <> wrote:
>> That would not achieve the goal of one limit only,
>> unless ChangeLogs have a hard limit of 80, and 74 is the soft limit.
>> [I'm treating "hard" as "do not violate unless there's a compelling reason",
>> and "soft" as a guideline. btw, I can no longer think of that word without also
>> thinking of Pirates of the Caribbean. :-)]
>> > Other than the opinion above, it's not really all that important to me.
>> > So I'm good with whatever reasonable limit the group decides. We just
>> > need to make sure we document the decision, with reference to the
>> > discussion.
>> I'm not overly fond of anything below 80 (well, 79, but I certainly
>> don't reject patches that use 80).
> I'm really easy, so I don't mind your proposal.
> Just for the record, to me, "soft" means "stay within the limit unless
> you have a reasonable reason to exceed", while "hard" means "do not
> exceed unless you just cannot do otherwise". As you can see, slightly
> stronger barriers. But I know also that it's really nitpicking, so
> I tend to worry too much about soft violations when reviewing patches,
> making that soft barrier a little softer :-). But I pay attention to
> that limit myself when modifying the code.

So how about a 74 soft limit and 80 hard limit for everything (modulo
things like .exp files where we try to keep things under 80 but  some
lines are just long and best left as is).

soft = "stay within the limit unless you have a reasonable reason to
exceed, and we're not nitpicky on what reasonable is"

hard = "do not exceed unless you just cannot do otherwise, and while
there are exceptions, we are quite nitpicky on this one"

Even that wording doesn't preclude different interpretations.  I'm
happy to tweak it.  The high order bits for me are the same numbers
for everything, and not being nitpicky on adherence to the soft limit.

If there are no objections, I will tweak your coding style cheat sheet
wiki (just trying to save you the trouble, it's your page, feel free
to edit as desired), and update other docs (the CodingStandards wiki
doesn't exist, I'll create it and add something to get it going).

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]